Allow calculating entanglement of left virtual boundary of finite MPS - #504
Merged
Conversation
lkdvos
reviewed
Aug 5, 2026
lkdvos
reviewed
Aug 5, 2026
lkdvos
left a comment
lkdvos
left a comment
Member
There was a problem hiding this comment.
Other than the minor comment, looks good to me, thanks!
lkdvos
approved these changes
Aug 5, 2026
lkdvos
enabled auto-merge (squash)
August 5, 2026 16:50
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was contemplating changing the argument also to
bondto refer to the actual cut location instead ofsite, so there's no confusion with left/right, but I decided ultimately against it and just added some clarification in the relevant docstrings.